Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: DedicatedWorkerGlobalScope.close() and SharedWorkerGlobalScope.close() return type - never #1806

Closed
wants to merge 1 commit into from
Closed

fix: DedicatedWorkerGlobalScope.close() and SharedWorkerGlobalScope.close() return type - never #1806

wants to merge 1 commit into from

Conversation

turansky
Copy link

  • DedicatedWorkerGlobalScope.close() - MDN
  • SharedWorkerGlobalScope.close() - MDN

@github-actions GitHub Actions
Copy link
Contributor

Thanks for the PR!

This section of the codebase is owned by @saschanaz - if they write a comment saying "LGTM" then it will be merged.

@turansky
Copy link
Author

@microsoft-github-policy-service agree

@saschanaz
Copy link
Contributor

saschanaz commented Sep 22, 2024 •
edited
Loading

This is not necessarily true:

new Worker(URL.createObjectURL(new Blob([`
  self.close();
  console.log("closed?");
`])))

// You can see "closed?" on devtools console

@turansky
Copy link
Author

@saschanaz thank you for example

@turansky turansky closed this Sep 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@turansky @saschanaz